Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR #740/d3e81b79 backport][stable-3] aws_s3: simplify the template check #743

Merged
merged 1 commit into from
Mar 28, 2022
Merged

[PR #740/d3e81b79 backport][stable-3] aws_s3: simplify the template check #743

merged 1 commit into from
Mar 28, 2022

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Mar 28, 2022

This is a backport of PR #740 as merged into main (d3e81b7).

Don't compare strings with \n character. This triggers errors like this:

fatal: [testhost]: FAILED! => {
    "msg": "The conditional check 'result.contents == \"template:\ntest template\n\"' failed. The error was: Invalid conditional detected: EOL while scanning string literal (<unknown>, line 1)"
}

@goneri @patchback
aws_s3: simplify the template check (#740)
7b641ea 
aws_s3: simplify the template check

Don't compare strings with \n character. This triggers errors like this:
fatal: [testhost]: FAILED! => {
    "msg": "The conditional check 'result.contents == \"template:\ntest template\n\"' failed. The error was: Invalid conditional detected: EOL while scanning string literal (<unknown>, line 1)"
}

Reviewed-by: Alina Buzachis <None>
(cherry picked from commit d3e81b7)
@patchback patchback bot mentioned this pull request Mar 28, 2022
Merged
@ansibullbot
Copy link

@patchback[bot]: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information.

Here are the items we could not find in your description:

  • issue type

Please set the description of this pullrequest with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/PULL_REQUEST_TEMPLATE.md

click here for bot help

@ansibullbot
Copy link

cc @jillr @linabuzachis @lwade @s-hertel @tremble
click here for bot help

@ansibullbot ansibullbot added integration tests/integration needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review tests tests labels Mar 28, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@alinabuzachis
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@alinabuzachis alinabuzachis added the mergeit Merge the PR (SoftwareFactory) label Mar 28, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 2857783 into stable-3 Mar 28, 2022
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-3/d3e81b791dce7f9e09c9475ddbaec89382daf859/pr-740 branch March 28, 2022 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
integration tests/integration mergeit Merge the PR (SoftwareFactory) needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ansibullbot @alinabuzachis @goneri